Resource pack callbacks are not triggered
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.3k
- Forks
- 960
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 2
Description
Expected Behavior
I expect the callbacks to be triggered just like the PlayerResourcePackStatusEvent works. There should be invocations of the callback for any change.
Actual Behavior
The callback is not invoked at all.
Steps to Reproduce
- Send a valid resource pack like below
- Wait for it to load successfully
- See that there is no log message
e.getPlayer().sendResourcePacks(
ResourcePackRequest.resourcePackRequest()
.packs(
ResourcePackInfo.resourcePackInfo()
.id(UUID.randomUUID())
.uri(URI.create("https://example.io/…"))
.hash("54ff1a362a90915aa44a3b3a5a…")
.build()
)
.replace(true)
.required(true)
.callback(ResourcePackCallback.onTerminal(
(uuid, audience) -> System.out.println("SUCCESSFULLY LOADED IT"),
(uuid, audience) -> System.out.println("FAILED TO LOAD IT")
))
.build()
);
Plugin List
Only the test plugin
Velocity Version
[23:27:39 INFO]: Velocity 3.3.0-SNAPSHOT (git-aa4e8780-b401)
[23:27:39 INFO]: Copyright 2018-2023 Velocity Contributors. Velocity ist lizenziert unter den Bedingungen der GNU General Public License v3.
[23:27:39 INFO]: velocitypowered.com - GitHub
Additional Information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ResourcePackCallback and the sendResourcePacks call shown in the reproduction, then compare their handling with PlayerResourcePackStatusEvent. Trace resource-pack status changes through the callback path; done means terminal success and failure callbacks are invoked and the behavior is covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100