Brand payload packets don't work
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 12.7k
- Forks
- 3.5k
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 11
Description
Expected behavior
Client brand packets should contain their brand.
Observed/Actual behavior
After recently updating paper, it seems like somehow brand packets are deserialized wrongly to have unknown brand payloads instead of net.minecraft.network.protocol.common.custom.BrandPayload, the result is that the .data() is an empty string instead of the client brand.
Steps/models to reproduce
Listen for payload packets
Plugin and Datapack List
Protocollib (for listening to the packets), i am just calling .getHandle() to get the raw NMS packet though
Paper version
This server is running Paper version git-Paper-"1865625" (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625)
You are 3 version(s) behind
Download the new version at: https://papermc.io/downloads/paper
Previous version: git-Paper-"4b0bc74" (MC: 1.20.2)
Other
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue while listening for payload packets through ProtocolLib and inspecting the raw NMS packet from getHandle(). Compare the deserialized brand packet with the expected net.minecraft.network.protocol.common.custom.BrandPayload and verify that its data() contains the client brand rather than an empty string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100