Add showToast to PlayerAdvancementDoneEvent
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 12.7k
- Forks
- 3.5k
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 11
Description
Is your feature request related to a problem?
There is currently no API way to do this, and brings some issues when trying to synchronize advancements between servers when players join them.
It would be preferred that when advancements that have been unlocked on the first server, that they would not give a toast popup anymore when the player goes to the second server.
Describe the solution you'd like.
Add a simple showToast(boolean) flag to the PlayerAdvancementDoneEvent,
hiding a toast in the "Update Advancements: Advancement display" packet is already possible, i assume it could be added relatively easily to the API?
Describe alternatives you've considered.
Editing the offline player data on the other server before they join would be a way to prevent the toast from sending, but i cant guarantee that that server is online at the time of advancement unlock, and all of that is not possible either with API
Other
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing PlayerAdvancementDoneEvent through the advancement handling path and the Update Advancements: Advancement display packet. Identify how the event result reaches the packet, then verify that a boolean showToast choice can be carried through. Done means callers can control whether the advancement toast is sent, with existing behavior preserved by default.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100