1.21.5 Update Todo

TODO:

• Check ServerLevel this.populating usage
• EntityRemoveEventTest
• Click and hover events
• Re-enable DFUCommandArgumentUpgraderCompatTest
• What do we want to do about shield delay config/api? Thats a data component now.
• Shield damage logic... how do move that over (awful damage event code)
• Should the TNTPrimeEvent be triggered as cancelled with the new game rule?
• The DispenseItemBehavior patch needs to be cleaned up, we have to make sure we call setSuccess properly. It may be a good opportunity to clean that patch up.
• Display.java - Is that vanilla bug fixed or do we still need to prevent logging: need to use readQuiet but is it even worth seems this would happen for every read* calls
• Do we still need StructureTemplate clearable diff? logic is moved with the flags but this cause some other issues, is the deadlock still relevant?
• Tickets got reworked, no longer hold a key. So other plugins can remove their tickets now. Do we care about this?
• Cactus growth modifier? This behavior is very different, how do we best represent this? https://github.com/PaperMC/Paper/issues/13644
• DO we still need the Record my movement through blocks spectator check? bug has been fixed
• Player movement packet no longer calls this.player.absMoveTo(d, d1, d2, f, f1); is anything expecting the position of the entity to change?
• net.minecraft.server.players.PlayerList#reloadAdvancementData showAdvancement?
• PlayerList#respawn ticket needs checking/testing
• nbt depth limit checks on scope
• Test inventory slots (Inventory split extra into entity equipment), horse inventories are broken (bad size/type/content)
• fix moved too quickly log (double check https://github.com/PaperMC/Paper/commit/eee862f577dcbf260e414631af240b4d00f6a887)
• fix tp stackoverflow (https://i.imgur.com/4DZRLw9.png)

API:

• ItemMeta
• Item data components
• Split thrown potion entity
• New entity variants
• New Blockstates
• New Blockdatas
• New gamerules
• Generator
• Test Biome#CUSTOM backwards compat/usage
• Look into bytecode rewriting for potion entity type and abstract cow.
• Backwards compatibility for TrimPattern in recipes by guessing from RecipeChoice

Doc:

• entities.spawning.filtered-entity-tag-nbt-paths world config default value changed
• Update brigadier section for new registries
• new test command permission

Review the unchecked checklist items, starting with the named entry points and tests such as ServerLevel, EntityRemoveEventTest, Display.java, StructureTemplate, PlayerList, and inventory tests. Narrow the work to one item before investigating; done is not defined beyond resolving or checking off the selected compatibility, behavior, or test concern.