Make `PrepareItemCraftEvent` fire for crafters
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 12.7k
- Forks
- 3.5k
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 11
Description
Is your feature request related to a problem?
When adding custom craftings manually, people may use the PrepareItemCraftEvent to edit the crafting result. However that currently doesn't work for crafters.
Describe the solution you'd like.
Make PrepareItemCraftEvent fire for crafters as well.
Describe alternatives you've considered.
There are no alternatives. The CrafterCraftEvent doesn't edit the crafter preview.
Other
This was implemented in Spigot after the hard fork, I don't really know how much the codebase changed, however you can find the commit that added this here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the referenced Spigot change in nms-patches/net/minecraft/world/inventory/ContainerWorkbench.patch with Paper's crafting-container implementation. Start from the PrepareItemCraftEvent and CrafterCraftEvent paths, then verify that the event fires for crafters and that its result can alter the crafter preview.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100