PaperMC / PaperMC/Paper

PotionSplashEvent doesn't prevent putting out fires

Open
#11,981 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: accepted version: 1.21.1
Dominant language
Java
Stars
12.7k
Forks
3.5k
Avg merge
3d 13h
Merged PRs (30d)
11

Description

Expected behavior

If you cancel the PotionSplashEvent, it should prevent putting out fires with water potions

Observed/Actual behavior

Fires are always put out regardless of cancellation

Steps/models to reproduce
  1. Throw water splash potion (or lingering) at a fire
  2. Cancel potion splash event
  3. Fire goes out
Plugin and Datapack List

N/A

Paper version

This server is running Paper version 1.21.1-132-ver/1.21.1@b48403b (2024-11-21T10:14:27Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.1-DEV-164e116 (MC: 1.21.1)

Other

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported PotionSplashEvent behavior with water and lingering potions against a fire, including cancellation. Trace the event-cancellation path and verify that a cancelled event no longer allows the fire to be put out; the issue is done when both potion types preserve the fire after cancellation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.