PaperMC / PaperMC/Paper

skip-vanilla-damage-tick-when-shield-blocked option removes block sound when enabled

Open
#11,761 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority: low status: input wanted version: 1.21.3 version: 1.21.4
Dominant language
Java
Stars
12.7k
Forks
3.5k
Avg merge
3d 13h
Merged PRs (30d)
11

Description

Expected behavior

When a player blocks their shield and another player hits it, the blocking player should hear a block sound in addition to a "weak attack" sound.

Observed/Actual behavior

The block sound does not play, instead only the "weak attack" sound plays.

Steps/models to reproduce
  1. Enable the skip-vanilla-damage-tick-when-shield-blocked option in paper-global.yml and start the server
  2. Join with 2 accounts and give one of them a shield and mute the audio on the other one
  3. Block your shield with said account (you can pause the game while blocking to continue blocking)
  4. Hit against the shield with the other account
  5. No block sound plays, only "weak attack"
Plugin and Datapack List

[18:13:53 INFO]: Server Plugins (0):

Paper version

[18:13:51 INFO]: Checking version, please wait...
[18:13:51 INFO]: This server is running Paper version 1.21.3-81-master@da71382 (2024-12-03T14:58:13Z) (Implementing API version 1.21.3-R0.1-SNAPSHOT)
You are running the latest version

Other

This did not happen on Paper 1.21.1.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the shield interaction with skip-vanilla-damage-tick-when-shield-blocked enabled in paper-global.yml, then compare the behavior with Paper 1.21.1 and 1.21.3. Trace the shield-block damage and sound handling; done means a blocked hit produces both the block sound and the "weak attack" sound.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.