PaperMC / PaperMC/Paper

Lidded containers closing issue

Open
#11,364 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #11814 by @456dev — closed without merging
status: accepted type: bug version: 1.21
Dominant language
Java
Stars
12.7k
Forks
3.5k
Avg merge
3d 13h
Merged PRs (30d)
11

Description

Expected behavior

I should be able to close any container implementing Lidded interface using method close().

Observed/Actual behavior

Every lidded container remained opened when there were viewers (even though it should be closed because the method for closing was called).

Steps/models to reproduce

Call Lidded#close(); on PlayerInteractEvent

Plugin and Datapack List

Mine and luckperms.

Paper version

This server is running Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21-129-4d7cef3 (MC: 1.21)

Other

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Lidded#close() when called from PlayerInteractEvent and inspect how viewers affect lidded containers. Reproduce the reported behavior on Paper 1.21-130 with a lidded container that has viewers. Done means every container implementing Lidded closes when close() is called, including when viewers are present.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.