Improve messages after upstream chunk api update
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 4.4k
- Forks
- 623
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem?
Yes, upstream removed the cached nms chunk from craftchunk, and every call to bukkit api chunks gets the chunk every time synchronously, which is redirected into a nms method which wasn't updated by folia, so it doesn't properly check for things and throw unsupported operation exceptions.
Describe the solution you'd like.
Update the used nms getChunk method or change the method to a newer one
Describe alternatives you've considered.
use proper isTickThread check (or maybe even better ensureTickThread)
Other
The people who used chunk object correctly and only from main thread shouldn't see a difference.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the NMS getChunk entry point used by the Bukkit chunk API and compare it with the upstream chunk API update and existing thread checks. Done means off-thread calls correctly enforce unsupported-operation behavior while correctly used main-thread chunk objects show no change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100