PaloAltoNetworks / PaloAltoNetworks/pan-os-python
BgpPolicyRule community_action_argument doesn't allow all valid input
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 400
- Forks
- 199
- PR merge metrics
- No merged PRs in 30d
Description
If you try to apply a non-default setting using the action_community_argument parameter in the BgpPolicyRule class you receive an error when you try to apply the change to a device
Describe the bug
If you try to apply a non-default setting using the action_community_argument parameter in the BgpPolicyRule class you receive an error when you try to apply the change to a device
Expected behavior
This parameter should allow all valid strings according to the documentation
Current behavior
An error is thrown
Possible solution
add a vartype='member' to the 'action_community_argument' VersionedParamPath within the BgpPolicyRule class in network.py
Steps to reproduce
- Create a BgpImportPolicyRule with action_community='append' and action_community_argument=65000:1
- Apply the change to an existing template
Screenshots
Context
Your Environment
I am attempting to make this change using Panorama version 8.1
- Version used: 0.14.0
- Environment name and version: python 3.8
- Operating System and version: Ubuntu 20.04
- Link to your project:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in network.py at the BgpPolicyRule class and inspect the VersionedParamPath for action_community_argument. Reproduce the BgpImportPolicyRule case with action_community='append' and action_community_argument=65000:1, then verify that valid documented strings can be applied to an existing template without an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100