POSYDON-code / POSYDON-code/POSYDON

[BUG]: SN_MODELS plotting

Open
#910 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Describe the bug
When wanting to output information from the SN_MODELS, we can no longer access it nicely PSyGrid interface of final_values.

Additionally, the were able to plot SN_MODEL_v2_01_CO_type in the 2d plotting, but now this also doesn't work, because these are no longer included in the final_values.

We should add back this functionality.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the PSyGrid interface populates final_values for SN_MODELS and how the 2D plotting path reads those values. Check the handling of SN_MODEL_v2_01_CO_type and compare it with other available model fields. Done means SN_MODELS information is accessible through final_values and SN_MODEL_v2_01_CO_type works again in 2D plots.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.