POSYDON-code / POSYDON-code/POSYDON
[BUG]: inlist_step2 not created for single_HeMS
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
Describe the bug
When running a single_HeMS MESA grid, inlist_step2 was not created during the posydon-setup-grid step, and then the HeMS models did not run fully.
To Reproduce
I copied this .ini file and used the following scenario:
scenario = ['posydon', 'matthias_lbv_thermo_dedt_noAgeLimit-dcc42e1d6d89fc267826970643e7f4f1bf463171', 'CO-He_star']
I then ran posydon-setup-grid. I initially got the following error:
We are going to dynamically fetch the posydon inlists based on your scenario
You have selected posydon as your source
checking if we have already cloned POSYDON-MESA-INLISTS for you
/home/oav5601/.conda/envs/posydon_env/bin/posydon-setup-grid:84: OverwriteWarning: 'git repository is already there, using that'
checking out branch: matthias_lbv_thermo_dedt_noAgeLimit
For posterity we are pulling (specifically needed if you already have the repo clone)
checking out commit/tag: dcc42e1d6d89fc267826970643e7f4f1bf463171
Based on system_type CO-He_star We are populating the posydon inlists in the following directory: /home/oav5601/.posydon_mesa_inlists/r11701/default_common_inlists/
Running Single Grid: Setting mesa_star1_extras to /home/oav5601/.posydon_mesa_inlists/r11701/default_common_inlists//binary/src/run_star_extras.f
Running Single Grid: Setting mesa_star2_extras to /home/oav5601/.posydon_mesa_inlists/r11701/default_common_inlists//binary/src/run_star_extras.f
Updating inifile values
Based on system_type CO-He_star We are populating the user inlists in the following directory: /home/oav5601/.posydon_mesa_inlists/r11701/CO-He_star/
We are making star2 so we can unset the zams file we were going to use for star2
These are the user inlists used in the single star grid: ['/home/oav5601/.posydon_mesa_inlists/r11701/CO-He_star/star1_formation/inlist_step1', '/home/oav5601/.posydon_mesa_inlists/r11701/CO-He_star/star1_formation/inlist_step2']
You want a single star He grid, this means that we need to make the inlist that will be used to evolve the system and make sure we layer on the line x_logical_ctrl(1)=.true.
/home/oav5601/.conda/envs/posydon_env/bin/posydon-setup-grid:356: OverwriteWarning: 'Replace /gpfs/home/oav5601/.posydon_mesa_inlists/special_single_star_user_inlist'
Traceback (most recent call last):
File "/home/oav5601/.conda/envs/posydon_env/bin/posydon-setup-grid", line 1024, in <module>
find_inlist_from_scenario(source=mesa_inlists['scenario'][0],
File "/home/oav5601/.conda/envs/posydon_env/bin/posydon-setup-grid", line 372, in find_inlist_from_scenario
mesa_inlists['star1_controls_special'].append(special_single_star_user_inlist)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'star1_controls_special'
This occurred because mesa_inlists['star1_controls_special'] did not already exist, and I fixed it by replacing the line with pass since it did not get referenced again.
However, although posydon-setup-grid would now run without error, it did not create an inlist_step2 file. Additionally, when I tried to run ./run_grid.sh, it threw errors that the Zbase of my ZAMS model did not match the one in the inlist files, rather than copying the Zbase (and initial_z and new_Z) from my grid.csv file.
Expected behavior
I expected it to create an inlist_step2 alongside steps 0 and 1.
POSYDON Version:
The error was with version 2.2.8.
Was able to fix it by using an older version, running source /projects/b1119/.bash_shared_fixed_rerun_implicit
System Configuration (please complete the following information):
Quest, Slurm
Additional context
Add any other context about the problem here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.