POSYDON-code / POSYDON-code/POSYDON
[BUG]: post-CE binaries have "initial_RLO"
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
Describe the bug
A post-CE BH + He star binary falls inside the "initial_RLO" region of the step_CO_HeMS grid. Given that we're verifying if the helium star fits inside the Roche lobe during step CE to determine a merger, it's unclear to me why these binaries become "initial RLO".
To Reproduce
At 0.01 Zsun with no natal kick
S1_mass | S2_mass | orbital_period
-- | -- | --|--
18.345936 | 12.543533 | 11.365167
Expected behavior
The systems should "merge" during the "step_CE" or continue evolving.
Example:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported system at 0.01 Zsun with no natal kick, then trace how it moves through the step_CE and step_CO_HeMS grid. Inspect the Roche-lobe check and the transition that assigns "initial_RLO". Done means the system merges during step_CE or continues evolving as expected, with regression coverage for the provided parameters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100