POSYDON-code / POSYDON-code/POSYDON
Incomplete calculation of the Bondi-Hoyle accretion rate
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
In common_functions.py we calculate the Bondi-Hoyle accretion rate, but this calculation is imperfect. In calculating it, we draw a random orbital phase. This is not the correct approach. Instead, we should be performing an orbit average - this has an analytic form. Note, it assumes some approximations (orbital periods are short).
Relevant code is in bondi_hoyle function in common_functions.py.
Specific code starts around lines 631
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in common_functions.py around line 631, at the bondi_hoyle function, and review the open pull request #926 for the current work. Replace the random orbital-phase calculation with the analytic orbit average described by the issue, accounting for its short-period approximation. Done means the rate no longer depends on a randomly drawn phase and uses the orbit-averaged result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100