POSYDON-code / POSYDON-code/POSYDON
[BUG]: Is singlestar.metallicity the absolute mass fraction of metals, or the ratio to solar fraction?
@maxbriel is already working on this.
Since Jan 16, 2026.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
In the singlestar class, from what I understand metallicity gets the values from the population run:
setattr(self, 'metallicity', kwargs.pop('metallicity', 1.0))
and
Z_div_Zsun = self.metallicity
However, the declaration of the variable in the singlestar properties is
'metallicity', # initial mass fraction of metals
So I am not sure if for Zsolar, singlestar.metallicity = 0.142 or 1.0
Do we just need to change the comment above next to the declaration?
Can we make sure that we are consistent across the posydon code for the use of singlestar.metallicity?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.