POSYDON-code / POSYDON-code/POSYDON
[BUG]: star_1.spin_orbit_tilt_second_SN's range is defined differently from other tilts.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
Describe the bug
star_1.spin_orbit_tilt_second_SN is calculated based on star_1.spin_orbit_tilt_first_SN and star_2.spin_orbit_tilt_second_SN. The latter two is defined in [-pi, pi] but the former is in [0, pi]
Expected behavior
The sign of star_1.spin_orbit_tilt_first_SN and star_2.spin_orbit_tilt_second_SN is needed when calculating star_1.spin_orbit_tilt_second_SN. But the sign is then not important for the final output of the star1 and star2 tilt. We ether put efforts to figure out the sign of star_1.spin_orbit_tilt_first_SN ([-pi, pi]), or simply output the absolute values ([0, pi]).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the calculation of star_1.spin_orbit_tilt_second_SN and comparing the ranges of the three named tilt variables. Resolve whether the signed range or absolute-value output is intended, then verify that the final star1 and star2 tilts use consistent ranges.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100