POSYDON-code / POSYDON-code/POSYDON
[BUG]: the `BinaryStar_output` and `SingleStar_1_output` ignored
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
Describe the bug
The parameters set in SingleStar_1_output, SingleStar_2_output, and BinaryStar_output are ignored when evolving a binary in isolation. Thus, the requested columns are not outputted.
To Reproduce
sim_prop = sim_props.from_ini('example_ini`, metallicity=1)
star_1 = SingleStar(**{'mass': 31.616785, 'state': 'H-rich_Core_H_burning',
'natal_kick_array': [0, 4.190728383757787, 1.1521129697118118, 5.015343794234789]})
star_2 = SingleStar(**{'mass': 26.874267, 'state': 'H-rich_Core_H_burning',
'natal_kick_array': [None, None, None, None]})
binary = BinaryStar(star_1, star_2, **{'time': 0.0, 'state': 'detached', 'event': 'ZAMS',
'orbital_period': 501.99252706449792,'eccentricity': 0.0}, properties = sim_prop)
binary.evolve()
binary.to_df()
binary.to_oneline_df()
Expected behavior
I expect binary.to_df() and binary.to_oneline_df() to return the columns set in the configuration file. Additional columns should still be allowed to be requested.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the configuration loaded by sim_props.from_ini and trace how SingleStar_1_output, SingleStar_2_output, and BinaryStar_output reach BinaryStar.evolve(), to_df(), and to_oneline_df(). Reproduce the example, then verify that configured columns appear in both outputs while explicitly requested additional columns remain supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100