POSYDON-code / POSYDON-code/POSYDON

[BUG]: scalar output is None pytables error

Open
#707 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Describe the bug
During the school, students ran into issues where the mt_history_XXXX was empty due to only evolving part of the evolution. Since we set these parameters to None at BinaryStar and SingleStar initialisation, this causes issues when the binary is written to the file. We should handle these in the "cleaning" of the output data before writing it to the file.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BinaryStar and SingleStar initialisation code and the cleaning step used before output is written. Trace how the mt_history_XXXX fields set to None are handled when only part of an evolution is present, and reproduce the PyTables failure if possible. Done means partially evolved binaries can be written without the scalar output error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.