POSYDON-code / POSYDON-code/POSYDON
Secondary mass vs. mass ratio
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
Currently, we have only the secondary mass (m2) specified for pop-syn. But for the first grid (HMS-HMS) we use the mass ratio (q). This causes values to be hard coded instead of being available to the user.
Following the discussions in PRs #271 and #302 we should get an update on the code to consider both m2 and q properly in an equal manner. This need updates in several parts of the code to work simultaneously together to both give the user all options (s)he wants and incorporates it in the structure of our grids.
So we should get rid of all the 0.5/m1 or 0.05*m1 throughout the code and have there the values inferred from the girds by PR #271 and extend them to have always both the q and m2 ranges available.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the requirements and prior discussions in PRs #271 and #302, focusing on the pop-syn code and the HMS-HMS first grid. Trace where m2, q, and the grid ranges are defined and where hard-coded 0.5/m1 or 0.05*m1 values are used. Done means users can provide both q and m2 ranges and the grid structure uses the selected values consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100