POSYDON-code / POSYDON-code/POSYDON

Invalid scenario system type silent errors during grid setup

Open
#490 2 comments 0 reactions 4 assignees View on GitHub

@maxbriel is already working on this.

Since Jan 23, 2025.

enhancement v2 feature
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

When a user specifies a system type incorrectly (e.g. CO-HMS instead of CO-H_star) the code should crash indicating this is not a valid option. Currently it prints out a misleading message that the system type is being read in leading to unexpected behavior. In this example it effectively evolves the system as HMS-HMS.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.