POSYDON-code / POSYDON-code/POSYDON

`find_nearest` in `gridutils`

Open
#465 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

find_nearest doesn't use: find_index_nearest_neighbour, which is available.

Additionally, it requires the input to be numpy.array's.
Can we change the code function to np.argmin()? And np.abs?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the gridutils implementation of find_nearest and compare it with the available find_index_nearest_neighbour function. Check how find_nearest handles its inputs and verify that the updated behavior works for inputs that are not numpy arrays, including the nearest-index result.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.