POSYDON-code / POSYDON-code/POSYDON

Undefined binaries in flow: ('stripped_He_Core_He_burning', 'H-rich_Core_He_burning', 'contact', None)

Open
#459 0 comments 0 reactions 1 assignee View on GitHub

@maxbriel is already working on this.

Since Apr 8, 2025.

bug help wanted question
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

When doing some tests for v2.0pre1, I have see in a NN run a case of

Traceback (most recent call last):
  File "/home/users/k/kruckow/POSYDON/posydon/popsyn/binarypopulation.py", line 325, in _safe_evolve
    binary.evolve()
  File "/home/users/k/kruckow/POSYDON/posydon/binary_evol/binarystar.py", line 219, in evolve
    self.run_step()
  File "/home/users/k/kruckow/POSYDON/posydon/binary_evol/binarystar.py", line 238, in run_step
    raise ValueError("Undefined next step given stars/binary states {}.".format(total_state))
ValueError: Undefined next step given stars/binary states ('stripped_He_Core_He_burning', 'H-rich_Core_He_burning', 'contact', None).

Failed Binary Initial Conditions:
S1 mass: 51.50296903439762
S2 mass: 49.40027877048686
S1 state: H-rich_Core_H_burning
S2 state: H-rich_Core_H_burning
orbital period: 67.68449970635564
eccentricity: 0.0
binary state: detached
binary event: detached
S1 natal kick array: [None None None None]
S2 natal kick array: [None None None None]

Shouldn't a contact have a CE as event? Is it may related to issue #369 ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.