POSYDON-code / POSYDON-code/POSYDON

Cleanup the order of definitions.

Open
#444 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue v2 feature
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Usually, all called should be defined beforehand and not afterwards. An example is posydon.utils.common_functions.Schwarzschild_Radius should be defined before posydon.utils.common_functions.CO_radius

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading posydon.utils.common_functions, especially the definitions of Schwarzschild_Radius and CO_radius. Inspect the surrounding definitions and identify other cases where a function is called before its definition. Done means the relevant definitions are ordered so called functions appear beforehand, with the module still importing successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.