POSYDON-code / POSYDON-code/POSYDON

Undefined binaries in flow: ('H-rich_Core_H_burning', 'H-rich_Core_H_burning', 'RLO2', 'oRLO2')

Open
#419 9 comments 0 reactions 3 assignees View on GitHub

Nobody has claimed this yet.

  • #615 by @philipp-rajah — closed without merging
P1 - high priority question v2 feature wontfix
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Binaries with the parameters ('H-rich_Core_H_burning', 'H-rich_Core_H_burning', 'RLO2', 'oRLO2') are failing because they are not handled in the flow. An example of one such binary:

ini_filepath_IF = "/projects/b1119/cliotine/pulsar_dev/pulsar_pops/runs/oct_2024/Sukhbold+16/grid_reruns_final/params.ini"
sim_kwargs_IF = simprop_kwargs_from_ini(ini_filepath_IF)
sim_prop_IF = SimulationProperties(**sim_kwargs_IF)
sim_prop_IF.load_steps(verbose=True)

star_1 = SingleStar(**{'mass':   6.263565862272097, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
star_2 = SingleStar(**{'mass': 4.042250364920023, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0,  'state': 'detached',  'event': 'ZAMS', 
                        'orbital_period':  2.3130949924692237, 'eccentricity': 0.0}, properties = sim_prop_IF)
binary_IF.evolve()
Screen Shot 2024-10-22 at 9 38 00 AM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.