POSYDON-code / POSYDON-code/POSYDON

incorrect assignment of "initial_RLOF" state

Open
#412 0 comments 0 reactions 2 assignees View on GitHub

@philipp-rajah is already working on this.

Since Apr 8, 2025.

bug v2 feature
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Some binaries are being assigned the "initial_RLOF" state late in their evolution, which is causing them to complete their evolution incorrectly. Here is an example (run with PR #404):

Screen Shot 2024-10-15 at 10 37 42 AM

Here are the conditions for re-running this binary with the file /projects/b1119/cliotine/dev_general/debugging/params.ini:

sim_kwargs_IF = simprop_kwargs_from_ini(ini_filepath_IF)
sim_prop_IF = SimulationProperties(**sim_kwargs_IF)
sim_prop_IF.load_steps(verbose=True)

star_1 = SingleStar(**{'mass': 9.207256, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [91.182965, 0.776432, 1.484747, 4.567527]})
star_2 = SingleStar(**{'mass': 9.093124, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0,  'state': 'detached',  'event': 'ZAMS', 
                        'orbital_period': 16.34274,'eccentricity': 0.0}, properties = sim_prop_IF)
binary_IF.evolve()

Per discussion with @mkruckow and @maxbriel , this seems like an issue with the interpolator, and it is possible we may need to add additional constraints when inferring the star state.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.