POSYDON-code / POSYDON-code/POSYDON

code not compliant with numpy 2.0

Open
#407 5 comments 0 reactions 1 assignee View on GitHub

@elizabethteng is already working on this.

Since Jan 29, 2025.

discuss enhancement
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Our setup.py requires numpy to be above 1.24 but otherwise doesn't specify. My most recent install chose numpy version 2, which was just released this June. This is breaking things for me as numpy 2.0 cleaned up the function namespace and eliminated a lot of common aliases for functions, some of which apparently exist in our code. We either need to specify numpy 1.24 in the requirements or update our code to comply with numpy 2.

The other major changes to numpy 2 were eliminating super-niche functions and allowing for custom datatypes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.