POSYDON-code / POSYDON-code/POSYDON

plot_pop_over_grid() change selection

Open
#383 0 comments 0 reactions 1 assignee View on GitHub

@maxbriel is already working on this.

Since Sep 12, 2024.

enhancement
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Currently, it's hardcoded what "event" from the binary is overplotted based on the grid choice selection.
That is HMS-HMS plots ZAMS, while CO-HMS plots RLO2 and CO-HeMS plots CE2.
These are very specific to BBH mergers.

This function should be altered to take the step_name which is closer to the grid that is being plotted.
This can either be a user input or a fixed value per grid.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.