POSYDON-code / POSYDON-code/POSYDON

Classification of contact system TF2s

Open
#369 2 comments 0 reactions 1 assignee View on GitHub

@sgossage is already working on this.

Since Aug 14, 2024.

discuss question
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

Putting this up for consideration:

In posydon/grids/termination_flags.py we have a check for contact as a termination flag as

134    if np.any(where_rl_rel_1 & where_rl_rel_2):
135        return "contact_during_MS"

which triggers whenever at any point during the history both stars overfilled their Roche lobe, rather than if they terminated in this way. In some cases systems may enter contact only for a brief time during the evolution and these will be given a termination_flag_2 of contact (either stable or unstable depending on various subsequent conditions).

Do we want to label/display any system that entered contact (no matter how brief) as contact? Should these systems truly be considered as contact?

Below is a grid slice at q = 0.99 from the 1e-4 Zsol grid. Points highlighted with red squares are contact systems that ultimately terminate out of contact, blue squares are those that ultimately terminate with star 1 RLOF only, cyan squares are those that go on to terminate with star 2 RLOF only (reverse MT).

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.