POSYDON-code / POSYDON-code/POSYDON

Remove classes from interpolator training, if they are underpopulated.

Open
#367 0 comments 0 reactions 1 assignee View on GitHub

@philipp-rajah is already working on this.

Since Jul 31, 2024.

enhancement
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

I think, the best way would be to remove interpolation classes from the interpolator training, if they are underpopulated.
I think, the exact number of needed systems (probably even within a cluster) will depend on the interpolation method. Hence, I think we should add this to the interpolation class itself. E.g. when the normalization is done, we should know the number of systems participating there already, thus I'd add there to mark an interpolation class there as to be excluded from thereon.
Ideally, we would not discard those systems, but move them to another interpolation class, but this might be very difficult to decide and may cause the interpolation errors to increase significantly. Therefore, an easy way is to exclude them in the first place.
In case, we'd still train the classifiers with this interpolation class, we can add a fallback for classes excluded from interpolation training to default to nearest neighbor, which should always work.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.