POSYDON-code / POSYDON-code/POSYDON
`CO/SN_type` double training?
Open
Nobody has claimed this yet.
v2 feature
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
In the posydon-run-pipeline, we're training the CO/SN_type for S1 twice. Once when we train the IFinterpolator for the MT classes, and once for the CO_interpolation_class.
@ZepeiX mentioned that adding this fixes discrepancies for too heavy NS masses.
From the code it doens't look like it changes, so it's a bit unclear why this changes.
We need a more thorough analysis of why this is changing/solving the issues we're seeing
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.