POSYDON-code / POSYDON-code/POSYDON

IFinterpolator: Core-collapse of secondary star

Open
#346 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue help wanted
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

The IF interpolator for core-collapse (CC) quantities is only trained for the collapse of the primary.

While it's rare that the secondary will explode first, we do not train any IF interpolators for such situations. These binaries might fail or do the collapse calculation using core masses or the NN. (which might mean properties will be missing).

Furthermore, we should investigate that these rare events are correctly considered in the final S1/S2_state classifier and the IF interpolator values.
No clear direction for this, but an important check if one wants to talk about mass ratio reversal in the HMS-HMS grid or more unique formation channels.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the IF interpolator and final S1/S2_state classifier for binaries where the secondary collapses first, then determine how those cases currently use core masses or the NN. Done means rare secondary-first events are correctly classified and their IF interpolator values are available.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.