POSYDON-code / POSYDON-code/POSYDON

Checks when steps get initialized

Open
#314 4 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement v2 feature
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

I recently experienced a case that step SN always failed, in the example it was caused by having no SN model which matches.
But instead of getting told about this at the beginning of the pop-syn, it run all through letting all systems entering the SN step fail there. Even more striking all systems which didn't get to this step evolved correctly, hence a quick check on a system, whether the run went well gave the wrong impression.

Hence, I'd suggest that we should add checks in the initialization of all steps to tell the user at this point if a step will always fail. I guess, this will be like the adding of the error and warning classes, that different people will need to do this for different steps.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.