POSYDON-code / POSYDON-code/POSYDON

SN properties not "restored" when running binary.restore()

Open
#308 0 comments 0 reactions 2 assignees View on GitHub

@maxbriel is already working on this.

Since Mar 31, 2025.

bug
Dominant language
Python
Stars
45
Forks
37
Avg merge
8d 20h
Merged PRs (30d)
5

Description

New binary attributes like first_SN_already_occurred have been added to step_SN from tilt tracking. When restoring binaries that have gone through SN to e.g. sample many kicks - these variables can break the binary in future evolution. This issue is to consider the scope of restore binary method to reset some of these properties. E.g. we may choose to explicitly not reset natal kick array.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.