POSYDON-code / POSYDON-code/POSYDON
NS/WD NaN mass, SN_type & CO_type not consistent
Open
Nobody has claimed this yet.
enhancement
help wanted
P1 - high priority
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
For systems with state=NS and SN_Type=WD, no mass is present in the MODELxx.
Is this expected behaviour for the models, when the state and SN type do not match?
Should we recalculate the mass with the state/SN_type based on the preSN model parameters?
STAR1 = SingleStar(**{'mass': 7.592921,
'state': 'H-rich_Core_H_burning'})
STAR2 = SingleStar(**{'mass':5.038679 ,
'state': 'H-rich_Core_H_burning'})
BINARY = BinaryStar(STAR1, STAR2,
**{'time': 0.0, 'state': 'detached', 'event': 'ZAMS', 'orbital_period':5.537807, 'eccentricity': 0.0},
properties = sim_pop)
| S1_mass | S2_mass | S1_he_core_mass | S1_co_core_mass | S1_state | S2_state | time | state | event | orbital_period | eccentricity |
|---|---|---|---|---|---|---|---|---|---|---|
| 7.592921 | 5.038679 | NaN | NaN | H-rich_Core_H_burning | H-rich_Core_H_burning | 0.000000e+00 | detached | ZAMS | 5.537807 | 0.0 |
| 1.229538 | 5.234164 | 1.229538 | 1.120187 | stripped_He_Central_He_depleted | H-rich_Core_H_burning | 5.204840e+07 | detached | CC1 | 11.434389 | 0.0 |
| NaN | 5.234164 | NaN | NaN | WD | H-rich_Core_H_burning | 5.204840e+07 | detached | NaN | 0.0 | |
| NaN | 5.234164 | NaN | NaN | WD | H-rich_Core_H_burning | 5.204840e+07 | detached | NaN | 0.0 |
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.