POSYDON-code / POSYDON-code/POSYDON
PR 229 - Open/Close input file overhead
@ka-rocha is already working on this.
Since Mar 14, 2024.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
In HDF5 read fix #229, the input file is opened and closed every time a new binary is loaded into the BinaryPopulation from a BinaryPopulation file to (re-)evolve, which feels inefficient.
Since we cannot keep the file open the whole time due to issue #224, we could read in a chunk of binaries in one-go before (re-)evolving them.
Is this something we want to implement, is this optimization necessary, and what's the actual overhead of reading one at the time?
Things to consider there is how much space the binaries take up and how the binaries are split between sub-processes?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.