POSYDON-code / POSYDON-code/POSYDON
Remove MPI for running grids
@ka-rocha is already working on this.
Since Oct 6, 2023.
- Dominant language
- Python
- Stars
- 45
- Forks
- 37
- Avg merge
- 8d 20h
- Merged PRs (30d)
- 5
Description
Today, I had a long meeting with the people from the HPC group.
They strongly encourage us to not use the python MPI, when we don't need it. They said, that in the current version, this module is not correctly initialized by us. It is even the case, that importing it while not initializing it correctly causes errors. The origin of the error is, that at some point slurm added to use MPI for the srun, hence there are two MPIs running at the same time, which causes conflicts, if they are not correctly initialized.
For this PR https://github.com/POSYDON-code/POSYDON/pull/143, I'll need to disable the automatic import of MPI4py. @ka-rocha, I guess, you have been the person putting it in for the dynamic grid creation, could you have a look to to correctly initialize the MPI and or think of a way to not use MPI for the dynamic grid creation. E.g. I'd think about generating a new slurm file for each new job and instead of running it directly, sbatch the new job. If there is any data, which needs to be transported from one instance to another we would may need to create temporary files to store that data between two runs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.