don't unregister callbacks automatically
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 319
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
In prio, we ran into a really awkward thing to debug:
tainted_prio<PrioNSSCtx*> nss = sandbox.malloc_in_sandbox<PrioNSSCtx>()
...
nss->NSS_IsInitialized = sandbox.register_callback(t_NSS_IsInitialized);
eneded up getting unregister at the end of the function call.
We probably want to just manually do the unregistering and have a separate type for automatically unregistering callbacks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing sandbox.register_callback and the callback lifetime shown in the issue. Determine how callbacks are currently unregistered at function exit and define the separate manually managed callback type; done means automatic cleanup is no longer applied to that type while explicit unregistering remains possible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100