comparing integers of different signs
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 319
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
In Prio, I"m getting a warning about int vs. size_t comparison here:
https://github.com/PLSysSec/rlbox_sandboxing_api/blob/master/code/include/rlbox_stdlib.hpp#L152-L154
In general we probably want to avoid this
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at code/include/rlbox_stdlib.hpp lines 152-154, where the int and size_t comparison warning is reported. Reproduce the warning in Prio and inspect nearby comparisons for the same issue. Done means the relevant signedness warning is resolved without changing the intended comparison behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100