PLC-lang / PLC-lang/rusty

Refactor default-value for constants into the pre-processor

Open
#665 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

low-priority refactor
Dominant language
Rust
Stars
362
Forks
75
Avg merge
6d 9h
Merged PRs (30d)
35

Description

Describe the solution you'd like
the PreProcessor should introduce the DefaultValue Placeholder, not the parser:
https://github.com/PLC-lang/rusty/pull/645/files/142cc79d6235d2be11b133decbf396719d5a681f#diff-4a04259da480a6b794a2e947e4cc03eff4d1aa9330836f5b91cac68c5398193fR1018-R1027

Additional context
this is a follow up issue to #645 - see https://github.com/PLC-lang/rusty/pull/645#discussion_r1031560672 for more information

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #645, especially the referenced parser changes and discussion, then trace how the PreProcessor and parser handle the DefaultValue Placeholder for constants. Done means the PreProcessor introduces the placeholder and the parser no longer does so, with the existing behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.