PHPCompatibility / PHPCompatibility/PHPCompatibilitySymfony
(Re-)enable attribute class polyfill related tests
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 8
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
The Symfony PHP 8.2, 8.4 and 8.5 polyfills all contain attribute class polyfills.
At this moment, it is not possible to modularly enough ignore notices about these attribute classes. This is annoying for users, on the other hand, if we would ignore the current error codes, the user may need see PHPCompatibility notices about other attributes, which also carries a risk.
All in all, the attribute detection and handling in PHPCompatibility itself needs to be improved before we can start ignoring usage of these polyfilled attributes.
I've opened an issue upstream about this: https://github.com/PHPCompatibility/PHPCompatibility/issues/1935
Once that issue has been addressed, the tests + rulesets in this package will need to be re-enabled/updated.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the upstream PHPCompatibility issue #1935 and the Symfony PHP 8.2, 8.4, and 8.5 polyfill handling described here. After the upstream attribute detection work is addressed, locate the disabled tests and rulesets in this package, update them as needed, and confirm the attribute-related checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100