PHOENIXCONTACT / PHOENIXCONTACT/MORYX-Framework

EntryConver: Simplify prototype and possible values

Open
#87 0 comments 0 reactions 1 assignee View on GitHub

@Toxantron is already working on this.

Since Nov 26, 2020.

enhancement
Dominant language
C#
Stars
57
Forks
39
Avg merge
1d 16h
Merged PRs (30d)
36

Description

Is your feature request related to a problem? Please describe.
Currently prototype keys are written to current value and must match entries in Value.Possible. This requires a lot of implicit knowledge and increases complexity because code is distributed over several places that all need to fit together. This happened, because prototypes were introduced as an addition to the Entry-format later.

Describe the solution you'd like
Possible values should only be relevant for primitive values. For classes and collections we use Prototypes and we should only use them. Instead of reading possible values and finding a match among the prototypes, we could directly populate from prototypes. I would also like to write prototype key to its identifier, which is currently "CREATED" and overwrite with "CREATED" when the prototype is instantiated.
The AddPrototype should also use the Identifier first and use the current behavior as a fallback, just like we keep possible values populated for this major.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.