PEtab-dev / PEtab-dev/petab_select
`analyze.compute_weights` does not permit a `str`-type criterion argument
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
But model.get_criterion does.
Reported by a user.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing analyze.compute_weights with model.get_criterion, focusing on how each handles the criterion argument type. Confirm the expected behavior for a str-type criterion and check the surrounding tests or test entry points; done means compute_weights accepts the same criterion form without breaking existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100