PEtab-dev / PEtab-dev/libpetab-python

Remove `v2.Problem.*_df`

Open
#409 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
18
Forks
9
PR merge metrics
No merged PRs in 30d

Description

After #405 , tables are kept separate. Providing the combined dataframe at e.g. petab_problem.condition_df will mean pre-existing code might silently fail because editing petab_problem.condition_df no longer changes the real condition table(s).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the repository for the v2.Problem dataframe attributes and read the context from issue #405. Confirm which separate tables replaced the combined dataframes, then remove the combined attributes while preserving the separate-table interface; done means the obsolete *_df properties are no longer provided.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.