PEtab-dev / PEtab-dev/PEtab

Clarify reinitialization for parameters in the condition table

Open
#513 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

v1
Dominant language
No language data
Stars
66
Forks
16
Avg merge
3h 2m
Merged PRs (30d)
10

Description

The current specifications describe re-initialization for species listed in the condition table. However, as noticed by @fbergmann, it is not clear how parameters that are targets of (implicitly or explicitly) time-dependent rules should be treated.
As those parameters are not excluded from being overwritten in the condition table, I'd say the most natural thing would be also re-iniitializing the corresponding states. Other thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the current specifications and the condition-table rules for parameters targeted by implicitly or explicitly time-dependent rules. Determine whether those parameters and their corresponding states should be reinitialized, then document the agreed behavior and update the relevant specification text. The issue does not name a specification file or test.

Written by the indexing model from the issue text.

Assessment

Domain
data, documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.