OvertureMaps / OvertureMaps/data

In `division_area`, the `class` attribute might mislead users

Open
#346 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

divisions
Dominant language
Python
Stars
1.2k
Forks
47
Avg merge
3h 42m
Merged PRs (30d)
1

Description

Querying for this feature might, under certain circumstances, give users a polygon that includes both land and maritime regions.

See the image below as an example: it's a query for subtype=region for the UK, Belgium, the Netherlands and Denmark.
The downloaded data has class=land, but the shapes clearly include both nautical zones and land cover.

The UK in particular just looks like a blob, and the Netherlands also has a lot of maritime area included by default.

Am I missing something here? Perhaps I am accessing land divisions incorrectly?

Image

Here is the duckdb query (I am using python). Subtype = 'region'

        COPY (
            SELECT
                names.primary AS overture_name,
                class,
                subtype,
                sources,
                id,
                geometry
            FROM
                read_parquet(
                    '{OVERTURE_LINK.format(version=version)}',
                    filename=true,
                    hive_partitioning=true
                )
            WHERE
                country == '{country_a2}'
                AND subtype == '{subtype}'
        )
        TO '{path}'
        WITH (
            FORMAT parquet,
            COMPRESSION zstd
        );
        """

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied DuckDB SQL query and the division_area results for subtype=region, especially the class and geometry fields. Compare the UK, Belgium, Netherlands, and Denmark examples to the expected land-division semantics. Done means determining whether maritime areas are included intentionally and clarifying or correcting the misleading classification or documented behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sql
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.