OriginProtocol / OriginProtocol/origin-dollar

Use multisend on Gnosis app

Open
#871 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dapp enhancement P2
Dominant language
Solidity
Stars
152
Forks
115
Avg merge
3d 20h
Merged PRs (30d)
17

Description

Our DApp currently block swaps from being queued up until the ERC20 approval has gone through. This is fine for EOA wallets but is quite painful on a multi-sig, where you need to go around up additional signers. You end up with 4 painful steps:

  1. Queue up the approval
  2. Go round up your cosigners to sign off on the approval
  3. Queue up the swap
  4. Go round up your cosigners again

We should copy 1inch, and take advantage of their multisend functionality to combine both the approval and swap into a single transaction, reducing this process to 2 steps:

  1. Queue up the approval & swap
  2. Go round up your cosigners

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the DApp's approval and swap queueing flow, with attention to how Gnosis multi-signature transactions are assembled. Compare the intended approach with 1inch's multisend functionality. Done means approval and swap can be queued together so cosigners need to approve only one transaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.