OriginProtocol / OriginProtocol/origin-dollar
No DApp Support for redeemAll
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 152
- Forks
- 115
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 17
Description
Unless I'm mistaken, the DApp no longer supports redeemAll after https://github.com/OriginProtocol/origin-dollar/pull/615. I would expect that function to be called if I click "Max" when swapping OUSD for the Mix via the vault. At our current rebase frequency, it's unlikely to result in a different outcome than redeem but this might change with more frequent rebases.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the DApp's vault swap flow for clicking "Max" while swapping OUSD for the Mix, then inspect how it selects between redeem and redeemAll. Done means the Max action invokes redeemAll as expected and the behavior is covered by the relevant existing tests, if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100