OriginProtocol / OriginProtocol/origin-dollar

Ambiguous Transaction Route Comparison

Open
#649 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dapp enhancement P3
Dominant language
Solidity
Stars
152
Forks
115
Avg merge
3d 20h
Merged PRs (30d)
17

Description

As a user, it's unclear to me in this example why Uniswap is not the best option. The "Est. received" is greater for Uniswap than it is for OUSD Swap, the "Effective price" appears to be the same since it's rounded off, and "+ $0.00" doesn't really make sense in red. I realize that the gas cost difference is what causes OUSD Swap to be the better option, but this requires some interpretation. Ideally, we would have another column showing the total cost or maybe show greater precision on the effective price and/or the diff.

Screen Shot 2021-08-21 at 8 46 47 AM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the transaction route comparison UI described in the issue and reproduce the Uniswap versus OUSD Swap display. Clarify whether the intended result is a total-cost column, greater effective-price precision, a clearer difference value, or a combination; done means the better route is unambiguous to users.

Written by the indexing model from the issue text.

Assessment

Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.