OriginProtocol / OriginProtocol/origin-dollar

Handle WalletConnect Disconnection

Open
#227 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dapp help wanted P3
Dominant language
Solidity
Stars
152
Forks
115
Avg merge
3d 20h
Merged PRs (30d)
17

Description

There are a few scenarios that can be problematic using WalletConnect. Here are a few that I have tested:

  • Disconnect using the "Cancel" button in Trust Wallet. The DApp will redirect to the home page and everything works as expected when you reconnect.
  • Disconnect using the "Disconnect" button in the DApp. Trust Wallet will remain "Online". Attempting to connect again from the DApp will cause a QR code to be shown, which might be a little confusing but is probably fine.
  • Disconnect using the "Disconnect" button in the DApp. Wait long enough for Trust wallet to change its status to "Offline". Attempting to connect again from the DApp will fail silently when clicking the WalletConnect button OR it will appear to connect and then fail silently when attempting to initiate a transaction.
  • Background Trust Wallet long enough that when you reopen it, the home screen is shown by default (instead of the browser connection). The connection won't work, nor will you get a QR code in the DApp by attempting to disconnect and reconnect. The DApp will think it is connected but not be able to initiate any transactions.

This is a low priority issue because I think users can repair their connections by disconnecting from both sides, refreshing the browser, and starting over.

I think @shahthepro was suggesting that these issues may require writing our own integration since web3-react seems to be problematic.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the WalletConnect and web3-react connection lifecycle, then reproduce the listed Trust Wallet disconnection and backgrounding scenarios; done means reconnecting and initiating a transaction work reliably or the failure is surfaced clearly.

Written by the indexing model from the issue text.

Assessment

Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.