OriginProtocol / OriginProtocol/origin-dollar
Dust in ConvexEthMetaStrategy
Open
Nobody has claimed this yet.
contracts
- Dominant language
- Solidity
- Stars
- 152
- Forks
- 115
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 17
Description
When withdrawing funds, we should deposit the full balance of ETH to WETH. This way we don't leave any intermediate ETH in the contract, and also the next depositAll() will pick up the funds.
weth.deposit{ value: _amount }();
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ConvexEthMetaStrategy and inspect the withdrawal path alongside depositAll(). Start from the existing weth.deposit call shown in the issue; done means the withdrawal deposits the full ETH balance so no intermediate ETH remains and a later depositAll() can pick it up.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100